Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: start GRPCWebServer in goroutine #9704

Merged
merged 4 commits into from
Jul 19, 2021
Merged

fix: start GRPCWebServer in goroutine #9704

merged 4 commits into from
Jul 19, 2021

Commits on Jul 16, 2021

  1. start GRPCWebServer in goroutine 

    so it don't block other code from executing.

Closes cosmos#9703

Update server/grpc/grpc_web.go

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

add changelog entry

Update server/grpc/grpc_web.go

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

change server start time to 3 seconds

and refactored to share a constant variable
    @yihuang
    yihuang committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    4a04673 View commit details
    Browse the repository at this point in the history

  2. change back to 5 seconds

    @yihuang
    yihuang committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    6576c72 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. fix race condition in test 

    credit to @robert-zaremba
    @yihuang
    yihuang committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    ab27b1c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-grpc-server

    @yihuang
    yihuang committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    a3b81c9 View commit details
    Browse the repository at this point in the history