Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename clientCtx.JSONMarshaler to JSONCodec #9251

Merged
merged 3 commits into from
May 3, 2021
Merged

Conversation

amaury1093
Copy link
Contributor

Description

follow-up: #9226
ref: #9218
ref: #9226 (comment)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@github-actions github-actions bot added T: ADR An issue or PR relating to an architectural decision record T:Docs Changes and features related to documentation. labels May 3, 2021
@amaury1093 amaury1093 marked this pull request as ready for review May 3, 2021 14:19
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #9251 (a8fca99) into master (d3bcc15) will not change coverage.
The diff coverage is 87.36%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9251   +/-   ##
=======================================
  Coverage   60.14%   60.14%           
=======================================
  Files         595      595           
  Lines       37194    37194           
=======================================
  Hits        22369    22369           
  Misses      12846    12846           
  Partials     1979     1979           
Impacted Files Coverage Δ
client/keys/add.go 62.50% <0.00%> (ø)
codec/amino_codec.go 100.00% <ø> (ø)
codec/proto_codec.go 73.41% <ø> (ø)
x/distribution/client/cli/tx.go 3.58% <0.00%> (ø)
x/genutil/client/cli/collect.go 0.00% <0.00%> (ø)
x/genutil/client/cli/gentx.go 0.00% <0.00%> (ø)
x/genutil/client/cli/validate_genesis.go 0.00% <0.00%> (ø)
x/genutil/client/testutil/helpers.go 0.00% <0.00%> (ø)
x/gov/client/cli/query.go 0.00% <0.00%> (ø)
x/gov/client/utils/query.go 28.16% <0.00%> (ø)
... and 18 more

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 3, 2021
@mergify mergify bot merged commit d19791b into master May 3, 2021
@mergify mergify bot deleted the am/json-marshaler branch May 3, 2021 14:45
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* Rename clientCtx.JSONMarshaler to JSONCodec

* change md files

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Keys Keybase, KMS and HSMs C:x/auth C:x/authz C:x/bank C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/mint C:x/params C:x/slashing C:x/staking T: ADR An issue or PR relating to an architectural decision record T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants