x/feegrant API Audit changes

[technicallyty]

Description

-changes keeper methods and proto messages to be more streamlined
-add comments to msg and query server
-remove decorator from docs
-add coments to msgs.go
-remove decorator from godoc

ref: #9115

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[blushi]

It seems like we're missing this point:

Same as in x/authz, we should simplify msg and types naming. Also (a FeeAllowanceGrant) GetFeeGrant() method naming is a bit confusing. Why not just use GetAllowance()?

In particular, I guess FeeAllowanceGrant could become AllowanceGrant (or even just Grant?), BasicFeeAllowance -> BasicAllowance, etc.

[codecov]

Codecov Report

Merging #9194 (3343f84) into master (711976e) will not change coverage.
The diff coverage is 78.75%.

@@           Coverage Diff           @@
##           master    #9194   +/-   ##
=======================================
  Coverage   60.14%   60.14%           
=======================================
  Files         595      595           
  Lines       37194    37194           
=======================================
  Hits        22369    22369           
  Misses      12846    12846           
  Partials     1979     1979           

Impacted Files	Coverage Δ
x/feegrant/types/basic_fee.go	75.00% <0.00%> (ø)
x/feegrant/types/filtered_fee.go	0.00% <0.00%> (ø)
x/feegrant/types/genesis.go	14.28% <0.00%> (ø)
x/feegrant/types/periodic_fee.go	56.25% <0.00%> (ø)
x/feegrant/types/grant.go	44.18% <18.18%> (ø)
x/feegrant/simulation/operations.go	76.99% <83.33%> (ø)
x/feegrant/client/testutil/suite.go	99.66% <100.00%> (ø)
x/feegrant/genesis.go	90.90% <100.00%> (ø)
x/feegrant/keeper/grpc_query.go	81.39% <100.00%> (ø)
x/feegrant/keeper/keeper.go	85.05% <100.00%> (ø)
... and 5 more

[technicallyty]

It seems like we're missing this point:

Same as in x/authz, we should simplify msg and types naming. Also (a FeeAllowanceGrant) GetFeeGrant() method naming is a bit confusing. Why not just use GetAllowance()?

In particular, I guess FeeAllowanceGrant could become AllowanceGrant (or even just Grant?), BasicFeeAllowance -> BasicAllowance, etc.

I slimmed down pretty much all the proto messages to be more to the point. FeeAllowanceGrant -> Grant and BasicFeeAllowance -> BasicAllowance etc. Let me know how this looks @blushi

[aaronc]

Looks okay from an API perspective. Are we removing height based expiration in a separate PR?

[technicallyty]

Looks okay from an API perspective. Are we removing height based expiration in a separate PR?

Yes @aleem1314 is taking care of that in another PR

[blushi]

LGTM!

[amaury1093]

@technicallyty Could you fix the conflicts?

[blushi]

@technicallyty could you fix the lint issues?

[technicallyty]

@AmauryM @blushi - lint + conflicts all cleared now 👍🏻