Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/authz: simulation audit changes #9107

Merged
merged 59 commits into from
May 11, 2021
Merged

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Apr 14, 2021

Description

ref: comment
ref: #9114


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #9107 (b12674a) into master (56c0595) will decrease coverage by 0.00%.
The diff coverage is 72.81%.

❗ Current head b12674a differs from pull request most recent head b25d776. Consider uploading reports for the commit b25d776 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9107      +/-   ##
==========================================
- Coverage   60.33%   60.33%   -0.01%     
==========================================
  Files         585      591       +6     
  Lines       36774    36955     +181     
==========================================
+ Hits        22188    22295     +107     
- Misses      12621    12685      +64     
- Partials     1965     1975      +10     
Impacted Files Coverage Δ
x/authz/simulation/operations.go 77.64% <69.41%> (-4.29%) ⬇️
x/authz/simulation/genesis.go 90.90% <88.88%> (+9.09%) ⬆️
client/keys/add.go 62.50% <0.00%> (ø)
version/command.go 83.33% <0.00%> (ø)
telemetry/metrics.go 56.86% <0.00%> (ø)
telemetry/wrapper.go 0.00% <0.00%> (ø)
x/genutil/client/cli/migrate.go 0.00% <0.00%> (ø)
x/auth/legacy/v039/migrate.go 17.14% <0.00%> (ø)
x/auth/legacy/v038/migrate.go 100.00% <0.00%> (ø)
x/genutil/legacy/v036/migrate.go 30.61% <0.00%> (ø)
... and 5 more

@robert-zaremba robert-zaremba self-assigned this May 10, 2021
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the codebase. One request change: let's don't confuse grant with Authorizaiton. Left few comments about it.

aleem1314 and others added 3 commits May 11, 2021 10:05
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@lgtm-com
Copy link

lgtm-com bot commented May 11, 2021

This pull request introduces 1 alert when merging c95c28f into 025d072 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can you avoid MustMarshalJSON usage

@aleem1314
Copy link
Contributor Author

looks good, can you avoid MustMarshalJSON usage

RandomizedGenState not return an error, I think MustMarshalJSON makes sense.

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 11, 2021
@amaury1093
Copy link
Contributor

@aleem1314 I just added automerge, is that okay?

@mergify mergify bot merged commit 8cfa2c2 into master May 11, 2021
@mergify mergify bot deleted the aleem/authz-simulation-audit-changes branch May 11, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Simulations C:x/authz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants