-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/authz: simulation audit changes #9107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9107 +/- ##
==========================================
- Coverage 60.33% 60.33% -0.01%
==========================================
Files 585 591 +6
Lines 36774 36955 +181
==========================================
+ Hits 22188 22295 +107
- Misses 12621 12685 +64
- Partials 1965 1975 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the codebase. One request change: let's don't confuse grant
with Authorizaiton. Left few comments about it.
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
This pull request introduces 1 alert when merging c95c28f into 025d072 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, can you avoid MustMarshalJSON
usage
|
@aleem1314 I just added automerge, is that okay? |
Description
ref: comment
ref: #9114
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes