Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reverse iteration to pagination #8875

Merged
merged 19 commits into from
Mar 23, 2021
Merged

Conversation

aleem1314
Copy link
Contributor

Description

closes: #8754


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@orijbot
Copy link

orijbot commented Mar 16, 2021

@orijbot
Copy link

orijbot commented Mar 16, 2021

@orijbot
Copy link

orijbot commented Mar 18, 2021

@orijbot
Copy link

orijbot commented Mar 18, 2021

@orijbot
Copy link

orijbot commented Mar 18, 2021

@orijbot
Copy link

orijbot commented Mar 18, 2021

@orijbot
Copy link

orijbot commented Mar 18, 2021

@orijbot
Copy link

orijbot commented Mar 18, 2021

@orijbot
Copy link

orijbot commented Mar 18, 2021

@orijbot
Copy link

orijbot commented Mar 18, 2021

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #8875 (0d2e9ac) into master (e30959c) will decrease coverage by 0.03%.
The diff coverage is 76.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8875      +/-   ##
==========================================
- Coverage   58.91%   58.88%   -0.04%     
==========================================
  Files         574      571       -3     
  Lines       32122    32114       -8     
==========================================
- Hits        18924    18909      -15     
- Misses      10979    10983       +4     
- Partials     2219     2222       +3     
Impacted Files Coverage Δ
client/flags/flags.go 20.40% <0.00%> (-0.43%) ⬇️
client/utils.go 43.33% <0.00%> (-3.10%) ⬇️
x/feegrant/keeper/keeper.go 78.65% <ø> (ø)
x/auth/ante/ante.go 66.66% <57.89%> (-33.34%) ⬇️
simapp/app.go 82.84% <81.81%> (-0.50%) ⬇️
x/auth/ante/fee.go 78.43% <83.33%> (+4.07%) ⬆️
types/query/filtered_pagination.go 80.76% <100.00%> (+6.25%) ⬆️
types/query/pagination.go 80.00% <100.00%> (+3.43%) ⬆️

@orijbot
Copy link

orijbot commented Mar 18, 2021

@aleem1314 aleem1314 marked this pull request as ready for review March 19, 2021 05:59
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@orijbot
Copy link

orijbot commented Mar 19, 2021

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you add a changelog entry? 🙏

client/flags/flags.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 23, 2021
@mergify mergify bot merged commit a78f777 into master Mar 23, 2021
@mergify mergify bot deleted the aleem/8754-reverse-iteration branch March 23, 2021 09:28
zakir-code pushed a commit to FunctionX/cosmos-sdk that referenced this pull request Apr 14, 2022
* WIP

* add tests

* add tests

* fix lint

* fix pagination

* add proto message doc

* fix filtered_pagination

* fix test

* cleanup

* add reverse flag to pagination

* changelog

* Update client/flags/flags.go

* Update CHANGELOG.md

Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

(cherry picked from commit a78f777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reverse iteration on pagination
5 participants