Keyring: Add trust to macOS Keychain for caller app by default #8826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit automatically trusts the calling application with its data, avoiding all the annoying keychain popups that appears when dealing with keys (list, add...).
Codecov Report
@@ Coverage Diff @@
## master #8826 +/- ##
==========================================
- Coverage 59.44% 59.44% -0.01%
==========================================
Files 563 563
Lines 31286 31287 +1
==========================================
Hits 18598 18598
- Misses 10522 10523 +1
Partials 2166 2166
|
alessio
approved these changes
Mar 10, 2021
zmanian
approved these changes
Mar 10, 2021
jgimeno
approved these changes
Mar 10, 2021
|
👏 |
alessio
added
the
A:automerge
mergify bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
This commit automatically trusts the calling application with its data, avoiding all the annoying keychain popups that appears when dealing with keys (list, add...). Co-authored-by: Alessio Treglia <alessio@tendermint.com> (cherry picked from commit d761f08)
alessio
pushed a commit
that referenced
this pull request
Mar 10, 2021
This commit automatically trusts the calling application with its data, avoiding all the annoying keychain popups that appears when dealing with keys (list, add...). Co-authored-by: Alessio Treglia <alessio@tendermint.com> (cherry picked from commit d761f08) Co-authored-by: Gianguido Sora <gsora@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR automatically trusts the calling application with its data,
avoiding all the annoying keychain popups that appears when dealing with
keys (list, add...).
closes: #8809
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes