Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Info Importer from legacy keybase #8500

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Remove Info Importer from legacy keybase #8500

merged 2 commits into from
Feb 3, 2021

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented Feb 3, 2021 •
edited
Loading

Description

Ref: #8436 (review)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@sahith-narahari sahith-narahari marked this pull request as ready for review February 3, 2021 11:54
amaury1093
amaury1093 approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@amaury1093 amaury1093 added C:Keys Keybase, KMS and HSMs Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Feb 3, 2021
@alessio alessio merged commit 2e9fd04 into master Feb 3, 2021
@alessio alessio deleted the sahith/remove-infoim branch February 3, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
C:Keys Keybase, KMS and HSMs Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sahith-narahari @amaury1093 @alessio