build(deps): bump google.golang.org/grpc from 1.33.2 to 1.34.0 #8162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
requested review from
aaronc,
alessio and
alexanderbez
as code owners
dependabot
bot
added
A:automerge
fedekunze
approved these changes
Dec 14, 2020
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.33.2 to 1.34.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.33.2...v1.34.0) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/google.golang.org/grpc-1.34.0
branch
from
5f0d116 to
ef206d5
Compare
alessio
requested review from
robert-zaremba,
sahith-narahari,
fdymylja and
jgimeno
|
Some tests panic here: cosmos-sdk/baseapp/grpcrouter.go Lines 98 to 99 in 1961935 and that's because I wonder if it's just a go-grpc<->gogoproto compatibility issue. |
robert-zaremba
approved these changes
Dec 20, 2020
alessio
suggested changes
Dec 20, 2020
alessio
removed
the
A:automerge
|
A newer version of google.golang.org/grpc exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
9 tasks
|
can someone update this? |
|
After some tests, the panic comes from grpc calling google.golang.org/protobuf@1.25.0 perhaps a module replace might fix this, but I'd have to test (NVM actually due to module path naming differences) Stack trace: |
Closed
4 tasks
shanev
approved these changes
Jan 21, 2021
|
Can I close this? I believe the correct fix is to update to go proto v2. There's an issue tracking this particular dep bump: #8392 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
amaury1093
deleted the
dependabot/go_modules/google.golang.org/grpc-1.34.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps google.golang.org/grpc from 1.33.2 to 1.34.0.
Release notes
Sourced from google.golang.org/grpc's releases.
Commits
2cf12a8Change version to 1.34.0 (#4042)f5c42caxds/client: Export a method to return bootstrap config. (#4033)b88744bxds: add ConfigSelector to support RouteAction timeouts (#3991)20636e7protobuf: update protoc to latest version (#4038)707e298internal: fix net.Dial fail without IP (#4037)1d01bf9grpclb: consider IDLE SubConns as connecting (#4031)90f1b3eclient: use "localhost:port" as authority if target is ":port" (#4017)22dba5exds: Remove usages of grpc.WithInsecure(). (#4028)d2629bdxds/bootstrap: Add support forgrpc_server_resource_name_id. (#4030)6caf9d8xds: make xds client a singleton (#4015)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)