Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to query ack proofs #7732

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Add function to query ack proofs #7732

merged 4 commits into from
Oct 29, 2020

Conversation

jackzampolin
Copy link
Member

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding

@jackzampolin jackzampolin added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 29, 2020
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably improve the name of the private function, but since it's private it doesn't matter too much.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #7732 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7732   +/-   ##
=======================================
  Coverage   54.21%   54.21%           
=======================================
  Files         611      611           
  Lines       38654    38654           
=======================================
  Hits        20956    20956           
  Misses      15564    15564           
  Partials     2134     2134           

@mergify mergify bot merged commit b2bc32f into master Oct 29, 2020
@mergify mergify bot deleted the jack/acks branch October 29, 2020 22:19
clevinson pushed a commit that referenced this pull request Oct 29, 2020
* Add function to query ack proofs

* Fix compilation issue

Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants