Add MsgServer to Configurator for ADR 031 wiring #7584

aaronc · 2020-10-16T15:12:13Z

closes: #7568

add MsgServer() to module Configurator
add an end-to-end integration test for bank send to verify that Msg services do indeed work
wire up all modules that have MsgServers in RegisterServices

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

codecov · 2020-10-16T15:18:07Z

Codecov Report

Merging #7584 into master will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@           Coverage Diff           @@
##           master    #7584   +/-   ##
=======================================
  Coverage   54.15%   54.16%           
=======================================
  Files         606      606           
  Lines       38187    38193    +6     
=======================================
+ Hits        20680    20686    +6     
  Misses      15410    15410           
  Partials     2097     2097

…ronc/7568-msg-server-configurator

types/module/configurator.go

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

clevinson

utACK

Preapproving with a few small naming nits / comment suggestions. Can also be tackled later in a separate PR.

Would be also good to get a changelog entry, or possibly combine with the changelog entry from @amaurymartiny here.

types/module/configurator.go

x/bank/client/cli/cli_test.go

Co-authored-by: Cory <cjlevinson@gmail.com>

amaury1093

lgtm

tests/mocks/account_retriever.go

aaronc · 2020-10-19T14:13:58Z

Can you re-review @alexanderbez or else give me a thumbs up on dismissing your change request?

aaronc · 2020-10-19T17:44:55Z

@alexanderbez I'm going to go ahead and dismiss your change request because that was addressed already so we can merge this.

Issue was addressed

* Add MsgServer to Configurator for ADR 031 wiring * Add docs, wire up evidence & staking * Add integration test * Add comments * Doc strings * Update types/module/configurator.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update types/module/configurator.go Co-authored-by: Cory <cjlevinson@gmail.com> * Wire up vesting * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Cory <cjlevinson@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Refactor RegisterQueryServices -> RegisterServices (#7518) * Refactor RegisterQueryServices -> RegisterServices * Fix tests * Add ADR 031 BaseApp and codec infrastructure (#7519) * Refactor RegisterQueryServices -> RegisterServices * Cleaner proto files * Fix tests * Add MsgServer * Fix lint * Remove MsgServer from configurator for now * Remove useless file * Fix build * typo * Add router * Fix test * WIP * Add router * Remove test helper * Add beginning of test * Move test to simapp? * ServiceMsg implement sdk.Msg * Add handler by MsgServiceRouter * Correct signature * Add full test * use TxEncoder * Update baseapp/msg_service_router.go Co-authored-by: Aaron Craelius <aaron@regen.network> * Push changes * WIP on ServiceMsg unpacking * Make TestMsgService test pass * Fix tests * Tidying up * Tidying up * Tidying up * Add JSON test * Add comments * Tidying * Lint * Register MsgRequest interface * Rename * Fix tests * RegisterCustomTypeURL * Add changelog entries * Put in features * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update baseapp/msg_service_router.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Address review comments * Address nit * Fix lint * Update codec/types/interface_registry.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * godoc Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Refactor x/bank according to ADR 031 (#7520) * Refactor x/bank according to ADR 031 * Add comment * Update comment * Add comment * Add tests, address edge cases * Imports Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/{gov, crisis} according to ADR 031 (#7533) * Refactor x/gov according to ADR 31 * fix tests * Refactor x/crisis according to ADR 031 * fix lint * lint * lint * review changes * lint * review change * fic doc Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/distribution according to ADR 031 (#7524) * Refactor x/distribution according to ADR 31 * lint * removed unused * Apply suggestions from code review Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * [x/slashing] Implement Protobuf Msg Services (#7557) * Update x/slashing to use proto msg service * Fix proto-gen Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/auth/vesting to use ADR-031 (#7551) * update auth/vesting module to use proto msg services * rm accidental tmp files * Update x/auth/vesting/msg_server.go Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * golangci-lint fix Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/staking according to ADR 031 (#7556) * Refactor x/staking according to ADR 031 * lint * review changes * review changes * review changes Co-authored-by: Aaron Craelius <aaron@regen.network> * Add MsgServer to Configurator for ADR 031 wiring (#7584) * Add MsgServer to Configurator for ADR 031 wiring * Add docs, wire up evidence & staking * Add integration test * Add comments * Doc strings * Update types/module/configurator.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update types/module/configurator.go Co-authored-by: Cory <cjlevinson@gmail.com> * Wire up vesting * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Cory <cjlevinson@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Refactor x/evidence to ADR-031 (#7538) * Refactor x/evidence to ADR-031 * Add hash in response * Update changelog * Update x/evidence/keeper/keeper.go * Update proto/cosmos/evidence/v1beta1/tx.proto Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Use msgServer struct Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> * Refactor x/ibc to ADR 031 (#7576) * WIP: Refactor x/ibc to ADR 031 * updated handler * removed unsued * fix * Add proto service for ibc/transfer * lint * remove old upgrade handler * added doc * review changes * fix tests * formatter * Add MsgServer wiring in RegisterServices Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * add changelog entries for non-nil Result.Data fields in message responses Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>

* Add MsgServer to Configurator for ADR 031 wiring * Add docs, wire up evidence & staking * Add integration test * Add comments * Doc strings * Update types/module/configurator.go Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update types/module/configurator.go Co-authored-by: Cory <cjlevinson@gmail.com> * Wire up vesting * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com> Co-authored-by: Cory <cjlevinson@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Add MsgServer to Configurator for ADR 031 wiring

2101536

aaronc added 5 commits October 16, 2020 14:04

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into aa…

5aa0aab

…ronc/7568-msg-server-configurator

Add docs, wire up evidence & staking

117bdbf

Add integration test

9c7ca75

Add comments

26bb673

Doc strings

4824a7a

aaronc marked this pull request as ready for review October 16, 2020 19:40

aaronc requested review from alessio and alexanderbez as code owners October 16, 2020 19:40

aaronc requested review from amaury1093, atheeshp, anilcse, blushi, clevinson and robert-zaremba October 16, 2020 19:40

aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 16, 2020

alexanderbez previously requested changes Oct 16, 2020

View reviewed changes

types/module/configurator.go Outdated Show resolved Hide resolved

Update types/module/configurator.go

573370f

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

aaronc requested a review from alexanderbez October 16, 2020 20:10

clevinson approved these changes Oct 16, 2020

View reviewed changes

types/module/configurator.go Show resolved Hide resolved

types/module/configurator.go Show resolved Hide resolved

x/bank/client/cli/cli_test.go Show resolved Hide resolved

Update types/module/configurator.go

9ec36b7

Co-authored-by: Cory <cjlevinson@gmail.com>

amaury1093 approved these changes Oct 19, 2020

View reviewed changes

tests/mocks/account_retriever.go Show resolved Hide resolved

mergify bot added 7 commits October 19, 2020 08:43

Merge branch 'master' into aaronc/7568-msg-server-configurator

a78cb65

Merge branch 'master' into aaronc/7568-msg-server-configurator

b4c7a90

Merge branch 'master' into aaronc/7568-msg-server-configurator

b7123f0

Merge branch 'master' into aaronc/7568-msg-server-configurator

c3dff2b

Merge branch 'master' into aaronc/7568-msg-server-configurator

24f1b2a

Merge branch 'master' into aaronc/7568-msg-server-configurator

e96f5fa

Merge branch 'master' into aaronc/7568-msg-server-configurator

85d858d

Wire up vesting

d493986

Update CHANGELOG.md

0ba94a4

mergify bot merged commit 9e7eb0d into master Oct 19, 2020

mergify bot deleted the aaronc/7568-msg-server-configurator branch October 19, 2020 17:46

aaronc mentioned this pull request Oct 19, 2020

Refactor x/ibc to ADR 031 #7576

Merged

9 tasks

clevinson mentioned this pull request Oct 19, 2020

[backport/v0.40.x] Implement ADR031 #7599

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MsgServer to Configurator for ADR 031 wiring #7584

Add MsgServer to Configurator for ADR 031 wiring #7584

aaronc commented Oct 16, 2020 •

edited

Loading

codecov bot commented Oct 16, 2020 •

edited

Loading

clevinson left a comment

amaury1093 left a comment

aaronc commented Oct 19, 2020

aaronc commented Oct 19, 2020

Add MsgServer to Configurator for ADR 031 wiring #7584

Add MsgServer to Configurator for ADR 031 wiring #7584

Conversation

aaronc commented Oct 16, 2020 • edited Loading

codecov bot commented Oct 16, 2020 • edited Loading

Codecov Report

clevinson left a comment

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

aaronc commented Oct 19, 2020

aaronc commented Oct 19, 2020

aaronc commented Oct 16, 2020 •

edited

Loading

codecov bot commented Oct 16, 2020 •

edited

Loading