Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple auth module from other SDK top-level core packages #7443

Closed
wants to merge 3 commits into from

Conversation

robert-zaremba
Copy link
Collaborator

Description

Cleaning dependencies and types between packages.
The general rule is always: what does lives outside of x/ should not depend on packages that live under x/.
This is also part of a proper OCAP work and general cleaning.

closes: #7318 and #7359


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc
Copy link
Member

aaronc commented Oct 2, 2020

I kind of have the idea that all of the basic tx related types and interfaces should live outside of x/auth and that only the ante handler itself should live x/auth (although maybe even that could get refactored out). The core purpose of x/auth should be just basic account and pubkey stuff. What do you think?

@robert-zaremba
Copy link
Collaborator Author

@aaronc - this is what I'm trying to do, but there is lot of cross dependencies between /client, /crypto and types. I'm not sure why do we have types/tx/signing. I'm trying to merge that package.
Also it seams that some types are not necessary. Lot of things to go through.

@aaronc
Copy link
Member

aaronc commented Oct 2, 2020

@aaronc - this is what I'm trying to do, but there is lot of cross dependencies between /client, /crypto and types. I'm not sure why do we have types/tx/signing. I'm trying to merge that package.

That needs to be separate out into a separate package from tx to avoid cyclic dependencies. This is a result of trying to support both StdTx and protobuf Tx.

Also it seams that some types are not necessary. Lot of things to go through.

Which types would you say aren't necessary?

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 17, 2020
@github-actions github-actions bot closed this Nov 23, 2020
@github-actions github-actions bot closed this Nov 30, 2020
@robert-zaremba robert-zaremba reopened this Dec 1, 2020
@github-actions github-actions bot closed this Dec 8, 2020
@tac0turtle tac0turtle deleted the robert/client-legacy-tx-test branch February 26, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple auth module from other SDK top-level core packages
2 participants