Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSON marshaler for base account #6054

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Remove JSON marshaler for base account #6054

merged 2 commits into from
Apr 22, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 22, 2020

Remove custom JSON marshaling for BaseAccount as multsigs cannot be bech32 decoded.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez marked this pull request as ready for review April 22, 2020 13:37
@alexanderbez alexanderbez self-assigned this Apr 22, 2020
@alexanderbez alexanderbez added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Apr 22, 2020
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #6054 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6054   +/-   ##
=======================================
  Coverage   54.69%   54.69%           
=======================================
  Files         424      424           
  Lines       25814    25790   -24     
=======================================
- Hits        14119    14107   -12     
+ Misses      10717    10708    -9     
+ Partials      978      975    -3     

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 22, 2020
@mergify mergify bot merged commit b737e7f into master Apr 22, 2020
@mergify mergify bot deleted the bez/remove-acc-json branch April 22, 2020 14:01
@assafmo
Copy link
Contributor

assafmo commented Apr 22, 2020

@alexanderbez Thanks for the swift response! 🎸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants