-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup for cli_test #6033
Merged
alexanderbez
merged 61 commits into
cosmos:master
from
regen-network:sahith/add-base-setup
Apr 29, 2020
Merged
Add setup for cli_test #6033
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
014caf8
Added cli integration base setup
sahith-narahari a42c097
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
sahith-narahari df53367
Added cmd to simapp
sahith-narahari c2e22b9
Fixed ci-lint issues
sahith-narahari 13b5531
Fixed ci-lint issues
sahith-narahari 858e744
Addressed changes in Makefile
sahith-narahari 0755f09
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
sahith-narahari 0ae1966
Updated simd to latest
sahith-narahari 6f362fd
Removed testnet and replay commands
sahith-narahari 5136a91
Modified tx command for simcli
sahith-narahari 295b023
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
sahith-narahari df2424a
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
sahith-narahari da5b8e3
Did code cleanup
sahith-narahari 6e82b44
Merge branch 'sahith/add-cli-tests' of github.com:regen-network/cosmo…
sahith-narahari 0ef94f2
Removed duplication in Makefile
sahith-narahari 6670f90
Refactored cli_test
sahith-narahari e130c40
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
sahith-narahari bc88c76
Added build-sim to Makefile
sahith-narahari baa4b60
Added test-cli to circleci
sahith-narahari 828092c
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
sahith-narahari 85fae47
Added tests for staking txns
5d33cbd
Addressed format issues
sahith-narahari 349e09d
Merge branch 'sahith/add-staking-tests' of github.com:regen-network/c…
sahith-narahari 61b6692
refctored tests code
0258675
Added tests for send, staking
sahith-narahari 8815250
Merge remote-tracking branch 'origin/atheesh/cli-test-send' into athe…
sahith-narahari 1b9c2ec
Removed test_hepers file
sahith-narahari 3101ed3
Moved test_cover to contrib
sahith-narahari 09efc33
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
sahith-narahari 93f1b09
Added codec in fixtures
cf27dff
Merge pull request #32 from vitwit/atheesh/cli-test-send
kaustubhkapatral d31c20d
Migrated tests to respective modules
sahith-narahari c083a83
Exported helper methods
sahith-narahari 4f03138
Merge branch 'sahith/add-base-setup' of github.com:regen-network/cosm…
sahith-narahari 82c0abc
Moved helpers to bank
sahith-narahari e67c965
Added codec to fixtures
sahith-narahari 71365b7
Migrated tests to modules
sahith-narahari 878bf70
Removed auth helpers from staking
sahith-narahari b272b89
Did minor code cleanup
sahith-narahari c94c654
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
sahith-narahari b3335b4
Added test-cli to Makefile
sahith-narahari 6f79058
Merge pull request #33 from regen-network/sahith/add-staking-tests
sahith-narahari 2fb801c
Updated github actions
sahith-narahari b867814
Merge branch 'sahith/add-base-setup' of github.com:regen-network/cosm…
sahith-narahari f41876b
Did code refactor
sahith-narahari 8237441
Fixed github actions for cli-test
sahith-narahari 7197e7d
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
sahith-narahari 2600b5d
Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…
sahith-narahari 044d318
Did minor code cleanup
sahith-narahari 6e90919
Added build flag to cli_tests
sahith-narahari 5fc398c
Moved cli_test to tests
sahith-narahari f351b47
Merge branch 'master' into sahith/add-base-setup
aaronc e400f11
Modified path in Makefile
sahith-narahari 53e8e9c
Merge branch 'sahith/add-base-setup' of github.com:regen-network/cosm…
sahith-narahari e3913ae
Updated codec std in fixtures
sahith-narahari 8454ecc
Added doc for cli tests
sahith-narahari 0b167c6
Remove ibc genesis validation
anilcse 55b8d0d
Fix issue number
anilcse 5e2446b
Merge branch 'master' into sahith/add-base-setup
aaronc 56fcb11
Merge branch 'master' into sahith/add-base-setup
aaronc 22d58ee
Merge branch 'master' into sahith/add-base-setup
aaronc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5948
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @anilcse has noted here, there is an issue with IBC
ValidateGenesis
that was breaking cli tests. I suggest we merge this PR withValidateGenesis
commented out like this so that cli tests can proceed. When the IBC team fixes this issue, they can uncomment these lines.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anilcse Is there a currently open issue / PR for tracking this and making sure this doesn't get forgotten? #5948 seems to be closed, and I cant find any open related issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Threre's none. May be we can reopen this issue: #6082
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DefaultGenesis is defined in
x/ibc/genesis.go