Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FlagKeyringBackend to QueryTxsByEventsCmd #5957

Merged
merged 4 commits into from
Apr 8, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Apr 8, 2020

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #5957 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5957      +/-   ##
==========================================
- Coverage   56.19%   56.18%   -0.01%     
==========================================
  Files         341      341              
  Lines       20430    20432       +2     
==========================================
  Hits        11480    11480              
- Misses       8080     8082       +2     
  Partials      870      870              

@jgimeno jgimeno marked this pull request as ready for review April 8, 2020 14:43
@alexanderbez
Copy link
Contributor

@jgimeno, for future reference, please try to remember to add all appropriate labels 👍 and use the PR template as best you can.

@jgimeno jgimeno changed the title Jonathan/hotfix get command flag keyring backend 2 Add flag to FlagKeyringBackend to QueryTxsByEventsCmd Apr 8, 2020
@alessio alessio merged commit 8eb4808 into master Apr 8, 2020
@alessio alessio deleted the jonathan/hotfix-get-command-flag-keyring-backend-2 branch April 8, 2020 15:17
@alessio alessio changed the title Add flag to FlagKeyringBackend to QueryTxsByEventsCmd Add FlagKeyringBackend to QueryTxsByEventsCmd Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants