Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/genutil: fix InitializeNodeValidatorFiles #5938

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Apr 6, 2020

fixes return values from InitializeNodeValidatorFiles function

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #5938 into master will not change coverage by %.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #5938   +/-   ##
=======================================
  Coverage   56.48%   56.48%           
=======================================
  Files         342      342           
  Lines       20270    20270           
=======================================
  Hits        11449    11449           
  Misses       7974     7974           
  Partials      847      847           

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@alexanderbez alexanderbez merged commit 7d6033e into master Apr 6, 2020
@alexanderbez alexanderbez deleted the patch-genutil branch April 6, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/genutil genutil module issues T:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants