Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: print an error message if the password input failed #5739

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

hsyis
Copy link
Contributor

@hsyis hsyis commented Mar 3, 2020

Closes: #XXX

Description

Error message is not printed when password input fails.
So it's hard to determine the cause.

> ${CLI} keys add jack
Enter keyring passphrase:
Enter keyring passphrase:
Enter keyring passphrase:
panic: too many failed passphrase attempts

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #5739 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5739      +/-   ##
==========================================
- Coverage   36.52%   36.52%   -0.01%     
==========================================
  Files         336      336              
  Lines       32742    32743       +1     
==========================================
  Hits        11958    11958              
- Misses      19555    19556       +1     
  Partials     1229     1229              

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK :)

@alexanderbez alexanderbez added C:Keys Keybase, KMS and HSMs R4R labels Mar 3, 2020
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Thanks!

@alessio alessio added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 3, 2020
@alessio alessio merged commit 70e8299 into cosmos:master Mar 3, 2020
@alessio alessio mentioned this pull request Mar 20, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants