Refactor use of parameters in x/distribution to match module spec #5506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
R4R
T: API Breaking
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5506 +/- ##
==========================================
- Coverage 54.54% 54.35% -0.19%
==========================================
Files 313 313
Lines 18875 18823 -52
==========================================
- Hits 10295 10232 -63
- Misses 7796 7812 +16
+ Partials 784 779 -5
|
jackzampolin
approved these changes
Jan 10, 2020
fedekunze
reviewed
Jan 10, 2020
| @@ -135,7 +135,7 @@ func CreateTestInputAdvanced(t *testing.T, isCheckTx bool, initPower int64, | |||
| sk := staking.NewKeeper(cdc, keyStaking, supplyKeeper, pk.Subspace(staking.DefaultParamspace)) | |||
| sk.SetParams(ctx, staking.DefaultParams()) | |||
|
|
|||
| keeper := NewKeeper(cdc, keyDistr, pk.Subspace(DefaultParamspace), sk, supplyKeeper, auth.FeeCollectorName, blacklistedAddrs) | |||
| keeper := NewKeeper(cdc, keyDistr, pk.Subspace(types.DefaultParamspace), sk, supplyKeeper, auth.FeeCollectorName, blacklistedAddrs) | |||
There was a problem hiding this comment.
we need to do a cleanup on the distr keeper tests eventually to use simapp
Codegnosis
added a commit
to unification-com/mainchain
that referenced
this pull request
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
x/distributionmade redundant use of parameters and did not follow the module spec. So we introduce aParamstype and remove a lot of cruft and duplicate code. Also, move all parameter related logic that should be intypes/fromkeeper/.ref: #5504
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)