Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom JSON Marshal/Unmarshal for Account Types #5280

Merged
merged 11 commits into from
Nov 6, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Nov 5, 2019

closes: #5270


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #5280 into master will increase coverage by 0.84%.
The diff coverage is 83.12%.

@@            Coverage Diff             @@
##           master    #5280      +/-   ##
==========================================
+ Coverage    53.5%   54.35%   +0.84%     
==========================================
  Files         290      290              
  Lines       17771    17899     +128     
==========================================
+ Hits         9509     9729     +220     
+ Misses       7511     7396     -115     
- Partials      751      774      +23

@alexanderbez alexanderbez merged commit 82a2c5d into master Nov 6, 2019
@alexanderbez alexanderbez deleted the bez/5270-mod-accnt-json branch November 6, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better ModuleAccount JSON serialization
2 participants