Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Query Gov Proposals Pagination #5216

Merged
merged 15 commits into from
Oct 18, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Oct 17, 2019

closes: #5212


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #5216 into master will increase coverage by 0.07%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master    #5216      +/-   ##
==========================================
+ Coverage   53.48%   53.55%   +0.07%     
==========================================
  Files         290      290              
  Lines       17724    17719       -5     
==========================================
+ Hits         9479     9489      +10     
+ Misses       7504     7489      -15     
  Partials      741      741

@alexanderbez alexanderbez added R4R and removed WIP labels Oct 18, 2019
@alexanderbez alexanderbez marked this pull request as ready for review October 18, 2019 15:20
@alexanderbez alexanderbez merged commit 84621bb into master Oct 18, 2019
@alexanderbez alexanderbez deleted the bez/5212-paginate-proposals branch October 18, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST query /gov/proposals does not support pagination.
2 participants