WIP: Pass AnteHandler and TxDecoder in constructor #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbrink
changed the title
ethanfrey
changed the title
|
Please make sure tests pass before marking it as ready for review. |
ebuchman
reviewed
Feb 28, 2018
| ) | ||
|
|
||
| func init() { | ||
| cdc = MakeTxCodec() |
There was a problem hiding this comment.
no globals please. let's just pass it into txDecoder
| @@ -53,13 +53,17 @@ type BaseApp struct { | |||
| var _ abci.Application = &BaseApp{} | |||
|
|
|||
| // Create and name new BaseApp | |||
| func NewBaseApp(name string, logger log.Logger, db dbm.DB) *BaseApp { | |||
| func NewBaseApp(name string, logger log.Logger, db dbm.DB, txDecoder sdk.TxDecoder, | |||
| ah sdk.AnteHandler) *BaseApp { | |||
There was a problem hiding this comment.
we now allow nil AnteHandler, so lets remove it from the constructor.
|
|
||
| // keys to access the substores | ||
| capKeyMainStore *sdk.KVStoreKey | ||
| capKeyIBCStore *sdk.KVStoreKey |
There was a problem hiding this comment.
better to comment out and add a note about using it in the future instead of just removing
|
Closing in favour of #559 |
MSalopek
added a commit
to MSalopek/cosmos-sdk
that referenced
this pull request
Feb 10, 2024
…smos#19314) (cosmos#512) Co-authored-by: MSalopek <matija.salopek994@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #480