refactor bank tests #4909
Merged
refactor bank tests #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-refactor-bank-tests
…-refactor-bank-tests
fedekunze
reviewed
Aug 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #4909 +/- ##
==========================================
+ Coverage 53.67% 53.73% +0.06%
==========================================
Files 272 272
Lines 17052 17105 +53
==========================================
+ Hits 9152 9191 +39
- Misses 7210 7223 +13
- Partials 690 691 +1 |
colin-axner
commented
Aug 16, 2019
| // genesis accounts. | ||
| func SetupWithGenesisAccounts(genAccs genaccounts.GenesisAccounts) *SimApp { | ||
| db := dbm.NewMemDB() | ||
| app := NewSimApp(log.NewTMLogger(log.NewSyncWriter(os.Stdout)), db, nil, true, 0) |
There was a problem hiding this comment.
should this be a Nop logger?
There was a problem hiding this comment.
I think this is fine, right? Might be helpful to see logs from modules as we're running integration tests.
colin-axner
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4875
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: