Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup + refactor Simapp #4811

Closed
wants to merge 3 commits into from
Closed

Cleanup + refactor Simapp #4811

wants to merge 3 commits into from

Conversation

fedekunze
Copy link
Collaborator

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@rigelrozanski
Copy link
Contributor

The weighted operations that are moved back into the modules should be given constant names as "DefaultXXXOperationWeight =... "

@fedekunze
Copy link
Collaborator Author

Closing as I'll split this PR into several ones for ease of reviewing

@fedekunze fedekunze closed this Aug 2, 2019
@fedekunze fedekunze deleted the fedekunze/simapp-cleanup branch August 2, 2019 15:43
@fedekunze fedekunze mentioned this pull request Aug 5, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedekunze @rigelrozanski