Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate remove and add permissions in ModuleAccount #4798

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

colin-axner
Copy link
Contributor

addresses problem mentioned in this issue.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@colin-axner colin-axner changed the title Deprecate remove and add permissions Deprecate remove and add permissions in ModuleAccount Jul 29, 2019
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #4798 into master will increase coverage by 3.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4798      +/-   ##
==========================================
+ Coverage    50.5%   53.86%   +3.35%     
==========================================
  Files         288      270      -18     
  Lines       18516    17222    -1294     
==========================================
- Hits         9351     9276      -75     
+ Misses       8480     7262    -1218     
+ Partials      685      684       -1

@fedekunze
Copy link
Collaborator

@alexanderbez do we want to cherry-pick this one too ?

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 83b1a9f into master Jul 31, 2019
@alexanderbez alexanderbez deleted the colin/4762-remove-modifying-permissions branch July 31, 2019 15:07
@alexanderbez
Copy link
Contributor

@alexanderbez do we want to cherry-pick this one too ?

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants