Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flag min-self-delegation #4764

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jul 23, 2019

Fixes: #4763

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze closed this Jul 23, 2019
@fedekunze fedekunze deleted the fedekunze/4763-fix-min-self-del branch July 23, 2019 14:51
@rigelrozanski
Copy link
Contributor

Was this fixed somewhere else?

@fedekunze fedekunze restored the fedekunze/4763-fix-min-self-del branch July 25, 2019 10:55
@fedekunze fedekunze reopened this Jul 25, 2019
@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #4764 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4764      +/-   ##
==========================================
+ Coverage   53.87%   53.88%   +<.01%     
==========================================
  Files         270      270              
  Lines       17230    17231       +1     
==========================================
+ Hits         9283     9285       +2     
+ Misses       7263     7262       -1     
  Partials      684      684

@alexanderbez alexanderbez merged commit e8a52f1 into master Jul 25, 2019
@alexanderbez alexanderbez deleted the fedekunze/4763-fix-min-self-del branch July 25, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditValidator command do not support min-self-delegation
4 participants