Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend DiffKVStores to return a list of KVPairs #4729

Merged
merged 4 commits into from
Jul 19, 2019
Merged

Extend DiffKVStores to return a list of KVPairs #4729

merged 4 commits into from
Jul 19, 2019

Conversation

fedekunze
Copy link
Collaborator

closes #4640

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 17, 2019 •
edited
Loading

Codecov Report

Merging #4729 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #4729      +/-   ##
==========================================
+ Coverage   53.98%   53.98%   +<.01%     
==========================================
  Files         272      272              
  Lines       17324    17326       +2     
==========================================
+ Hits         9352     9354       +2     
  Misses       7290     7290              
  Partials      682      682

@fedekunze fedekunze requested a review from mircea-c July 17, 2019 16:42
mircea-c
mircea-c approved these changes Jul 17, 2019
View reviewed changes
Copy link

@mircea-c mircea-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fedekunze fedekunze requested a review from colin-axner July 18, 2019 08:17
alexanderbez
alexanderbez suggested changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, otherwise LGTM.

colin-axner
colin-axner approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@fedekunze fedekunze requested a review from alexanderbez July 18, 2019 22:18
@alexanderbez alexanderbez merged commit b17f8f8 into master Jul 19, 2019
@alexanderbez alexanderbez deleted the fedekunze/4640-diffkvstores branch July 19, 2019 14:05
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@fedekunze @alexanderbez
Merge PR cosmos#4729: Extend DiffKVStores to return a list of KVPairs
130f356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@mircea-c mircea-c mircea-c approved these changes

@colin-axner colin-axner colin-axner approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:Simulations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend DiffKVStores to return an array of KVPairs
4 participants
@fedekunze @alexanderbez @mircea-c @colin-axner