Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify context #4706

Merged
merged 11 commits into from
Jul 16, 2019
Merged

Simplify context #4706

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
47cf556
Simplify Context into a proper structure
ethanfrey Jul 10, 2019
1001022
Fix build errors
ethanfrey Jul 10, 2019
464168d
All tests pass
ethanfrey Jul 10, 2019
cd9ac34
Cleanup
ethanfrey Jul 10, 2019
2a665da
Add changelog entry
ethanfrey Jul 10, 2019
ae32c74
Addressed PR comments
ethanfrey Jul 10, 2019
1f631f5
Clone protobuf header/consensus and add tests
ethanfrey Jul 11, 2019
346e3a2
Reproduced error with cloning non-UTC time
ethanfrey Jul 11, 2019
a0f6e4d
Fix Clone by forcing all Header.Time in Context to be UTC
ethanfrey Jul 11, 2019
c38363d
Update types.Context docs
ethanfrey Jul 11, 2019
93d98c4
Apply suggestions from code review
ethanfrey Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .pending/improvements/sdk/4706-Simplify-context
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
4706 - Simplify context

Replace complex Context construct with a simpler immutible struct.
Only breaking change is not to support `Value` and `GetValue` as first class calls.
We do embed ctx.Context() as a raw context.Context instead to be used as you see fit.

Migration guide:
`ctx = ctx.WithValue(contextKeyBadProposal, false)` ->
`ctx = ctx.WithContext(context.WithValue(ctx.Context(), contextKeyBadProposal, false))`
A bit more verbose, but also allows `context.WithTimeout()`, etc and only used
in one function in this repo, in test code.
Loading