Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint #4636

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Update golangci-lint #4636

merged 2 commits into from
Jun 28, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 28, 2019

Update golangci-lint to latest version.

Remove ci-lint, no longer used.

Remove golangci-lint from tools target to prevent CI builds
from downloading automatically (and unnecessarily).
Developers can still run make golangci-lint to download
it locally for development and testing purposes.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

alessio added 2 commits June 28, 2019 12:35
The lint target is not executed by default anymore on ci builds.
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #4636 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4636      +/-   ##
==========================================
+ Coverage   54.11%   54.12%   +0.01%     
==========================================
  Files         260      260              
  Lines       16371    16371              
==========================================
+ Hits         8859     8861       +2     
+ Misses       6866     6864       -2     
  Partials      646      646

@alessio alessio changed the title Alessio/update golangci lint Update golangci-lint Jun 28, 2019
@alessio alessio marked this pull request as ready for review June 28, 2019 13:37
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. However, are we sure we want to remove this from the tools target?

@alexanderbez alexanderbez added build and removed WIP labels Jun 28, 2019
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Show resolved Hide resolved
@alessio alessio merged commit a579156 into master Jun 28, 2019
@alessio alessio deleted the alessio/update-golangci-lint branch June 28, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants