Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass height to RPC calls #4307

Merged
merged 3 commits into from
May 9, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented May 8, 2019

When passed nil, Tendermint will assume latest height. Not only does this provide cleaner code, but also fixes a bug where there could be a discrepancy between the consensus height and the node status' height.

/cc @faboweb


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #4307 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4307   +/-   ##
=======================================
  Coverage   59.38%   59.38%           
=======================================
  Files         214      214           
  Lines       14531    14531           
=======================================
  Hits         8629     8629           
  Misses       5264     5264           
  Partials      638      638

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ACK'd - pending changelog entry

@alexanderbez alexanderbez merged commit 829ce17 into master May 9, 2019
@alexanderbez alexanderbez deleted the bez/fix-rpc-height-commands branch May 9, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants