Param Proposal Simulation Messages; Minting Params Fix #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
commented
May 1, 2019
| @@ -76,24 +92,6 @@ func SimulateSubmittingVotingAndSlashingForProposal(k gov.Keeper) simulation.Ope | |||
| } | |||
| } | |||
|
|
|||
| // SimulateMsgSubmitProposal simulates a msg Submit Proposal | |||
| // Note: Currently doesn't ensure that the proposal txt is in JSON form | |||
| func SimulateMsgSubmitProposal(k gov.Keeper) simulation.Operation { | |||
alexanderbez
requested review from
alessio,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4244 +/- ##
==========================================
- Coverage 60.42% 60.42% -0.01%
==========================================
Files 218 218
Lines 15421 15426 +5
==========================================
+ Hits 9318 9321 +3
- Misses 5452 5454 +2
Partials 651 651 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4244 +/- ##
==========================================
- Coverage 60.42% 60.42% -0.01%
==========================================
Files 218 218
Lines 15421 15426 +5
==========================================
+ Hits 9318 9321 +3
- Misses 5452 5454 +2
Partials 651 651 |
cwgoes
reviewed
May 1, 2019
fedekunze
reviewed
May 2, 2019
| @@ -197,11 +198,11 @@ func appStateRandomizedFn(r *rand.Rand, accs []simulation.Account, genesisTimest | |||
| slashingGenesis := slashing.GenesisState{ | |||
There was a problem hiding this comment.
Unfortunately, slashing has no such function. Separate PR.
| @@ -6,6 +6,8 @@ import ( | |||
| "github.com/cosmos/cosmos-sdk/x/params" | |||
| ) | |||
|
|
|||
| var minterKey = []byte{0x00} // the one key to use for the keeper store | |||
|
|
|||
| const ( | |||
| // ModuleName is the name of the module | |||
| ModuleName = "minting" | |||
There was a problem hiding this comment.
this differs with the module name (?)
There was a problem hiding this comment.
indeed. I didn't write this module -- it should be changed. Separate PR though.
|
|
||
| // Implements params.ParamSet | ||
| func (p *Params) ParamSetPairs() params.ParamSetPairs { | ||
| return params.ParamSetPairs{ |
There was a problem hiding this comment.
it'd be cool to use params.NewParamSetPairs here
There was a problem hiding this comment.
I don't think we need New* constructor for slice literals, but certainly their contents.
|
Addressed your comments @fedekunze |
jackzampolin
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
params.ParamSetso we can set params with their respective unique keys individuallycloses: #4235
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: