Allow tx send (generate-only) to actually work offline #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
alessio,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4234 +/- ##
==========================================
- Coverage 60.15% 60.13% -0.02%
==========================================
Files 212 212
Lines 15223 15223
==========================================
- Hits 9157 9155 -2
- Misses 5431 5433 +2
Partials 635 635 |
fedekunze
approved these changes
Apr 30, 2019
| @@ -29,10 +29,6 @@ func SendTxCmd(cdc *codec.Codec) *cobra.Command { | |||
| WithCodec(cdc). | |||
| WithAccountDecoder(cdc) | |||
|
|
|||
| if err := cliCtx.EnsureAccountExists(); err != nil { | |||
| return err | |||
| } | |||
There was a problem hiding this comment.
should disable this test only when generate mode is on (and leave it otherwise)?
There was a problem hiding this comment.
Good question, but no need to. No other command work like this. When you omit --generate-only, EnsureAccountExists does get called. So having it here was wrong and superfluous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: