Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic version cmd for basecoind #396

Merged
merged 2 commits into from
Feb 2, 2018
Merged

Conversation

adrianbrink
Copy link
Contributor

@adrianbrink adrianbrink commented Jan 29, 2018

closes #395

@adrianbrink adrianbrink requested a review from jaekwon as a code owner January 29, 2018 09:27
@adrianbrink adrianbrink changed the base branch from sdk2 to develop January 29, 2018 09:54
The example app should probably have the same version as the sdk.
@adrianbrink
Copy link
Contributor Author

The failure comes from the invalid glide.yaml file.
#397 fixes that.

Copy link
Contributor

@zramsay zramsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@zramsay zramsay changed the base branch from develop to consolidate February 2, 2018 23:28
@zramsay
Copy link
Contributor

zramsay commented Feb 2, 2018

merging to consolidate

@zramsay zramsay merged commit d948fff into consolidate Feb 2, 2018
@zramsay zramsay deleted the feature/sdk2-version branch February 2, 2018 23:29
ParthDesai pushed a commit to ChorusOne/cosmos-sdk that referenced this pull request Apr 19, 2021
rootulp referenced this pull request in rootulp/cosmos-sdk Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants