-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Minting mechanism explanatory docs #3894
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3894 +/- ##
===========================================
- Coverage 60.95% 60.94% -0.02%
===========================================
Files 192 192
Lines 14360 14360
===========================================
- Hits 8753 8751 -2
- Misses 5033 5035 +2
Partials 574 574 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM. Left a few remarks ⚡️
Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>
…osmos-sdk into rigel/minting-expl-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; a few clarification suggestions.
Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>
C'est Bizarre! It looks like the CI doesn't run for code merged conducted from Github PR suggestions |
closes #3752
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: