Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove governance_penalty #3758

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Feb 27, 2019

Closes #3753

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #3758 into develop will increase coverage by 0.03%.
The diff coverage is 60%.

@@             Coverage Diff             @@
##           develop    #3758      +/-   ##
===========================================
+ Coverage    61.12%   61.16%   +0.03%     
===========================================
  Files          189      189              
  Lines        14054    14048       -6     
===========================================
+ Hits          8591     8592       +1     
+ Misses        4925     4918       -7     
  Partials       538      538

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackzampolin jackzampolin merged commit e2baa38 into develop Feb 27, 2019
@jackzampolin jackzampolin deleted the cwgoes/remove-governance-penalty branch February 27, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants