R4R: Gentx workflow for offline keys #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnya97
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
sunnya97
changed the title
cwgoes
reviewed
Feb 25, 2019
cwgoes
suggested changes
Feb 25, 2019
|
bump @sunnya97 |
cwgoes
approved these changes
Feb 27, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3734 +/- ##
=========================================
Coverage ? 61.2%
=========================================
Files ? 190
Lines ? 14042
Branches ? 0
=========================================
Hits ? 8595
Misses ? 4909
Partials ? 538 |
| return err | ||
| } | ||
|
|
||
| if info.GetType() == kbkeys.TypeOffline { |
There was a problem hiding this comment.
With #3748, multisig will have their own dedicated Info type (TypeMulti). Will we have to check both here?
There was a problem hiding this comment.
Should we wait to merge this then? Or rebase it on your branch?
There was a problem hiding this comment.
I say we merge this and then I can rebase/update.
| } | ||
|
|
||
| if info.GetType() == kbkeys.TypeOffline { | ||
| fmt.Println("Offline key passed in. Use `gaiacli tx sign` command to sign:") |
There was a problem hiding this comment.
Suggested change
| fmt.Println("Offline key passed in. Use `gaiacli tx sign` command to sign:") | |
| fmt.Println("Offline key passed in. Use `gaiacli tx sign` command to sign:") |
jackzampolin
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3730
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: