Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Alternative negative coins fix (floor multiplication) #3728

Merged
merged 7 commits into from
Feb 26, 2019
Merged

R4R: Alternative negative coins fix (floor multiplication) #3728

merged 7 commits into from
Feb 26, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Feb 25, 2019 •
edited
Loading

Closes #3723
Complements #3726
Replaces #3722

Standard checklist:

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added T:Bug C:x/distribution distribution module related labels Feb 25, 2019
@cwgoes cwgoes marked this pull request as ready for review February 25, 2019 15:05
This was referenced Feb 25, 2019
Merged
Closed
alexanderbez
alexanderbez reviewed Feb 25, 2019
View reviewed changes
x/distribution/keeper/allocation_test.go Outdated Show resolved Hide resolved
x/distribution/keeper/allocation_test.go Outdated Show resolved Hide resolved
x/distribution/keeper/allocation_test.go Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Contributor

TestBonding strikes again!

@codecov
Copy link

codecov bot commented Feb 25, 2019 •
edited
Loading

Codecov Report

Merging #3728 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #3728   +/-   ##
========================================
  Coverage    61.15%   61.15%           
========================================
  Files          189      189           
  Lines        14052    14052           
========================================
  Hits          8593     8593           
  Misses        4921     4921           
  Partials       538      538

@cwgoes cwgoes mentioned this pull request Feb 25, 2019
Closed
@cwgoes cwgoes added this to the v0.33.0 (Launch) milestone Feb 25, 2019
@rigelrozanski
Copy link
Contributor

p.s. here opened an issue for the non-deterministic lcd bug here #3739

@cwgoes cwgoes changed the title Alternative negative coins fix (floor multiplication) R4R: Alternative negative coins fix (floor multiplication) Feb 26, 2019
@cwgoes cwgoes requested a review from sunnya97 February 26, 2019 11:45
@cwgoes cwgoes mentioned this pull request Feb 26, 2019
Closed
alexanderbez
alexanderbez approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- pending log needs fixing.

@jackzampolin jackzampolin merged commit 7cddda7 into develop Feb 26, 2019
@jackzampolin
Copy link
Member

Is this ready to merge? Or are we waiting on #3746

@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 26, 2019

Merging this is fine.

@cwgoes cwgoes deleted the cwgoes/alternative-negative-coins-fix branch March 4, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@sunnya97 sunnya97 Awaiting requested review from sunnya97

Assignees
No one assigned
Labels
C:x/distribution distribution module related T:Bug
Projects
None yet
Milestone
v0.33.0 (Launch)
Development

Successfully merging this pull request may close these issues.
5 participants
@cwgoes @alexanderbez @rigelrozanski @jackzampolin @hleb-albau