Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Upgrade to tendermint 0.30.0 final #3618

Merged
merged 1 commit into from
Feb 12, 2019
Merged

R4R: Upgrade to tendermint 0.30.0 final #3618

merged 1 commit into from
Feb 12, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 12, 2019

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio changed the title Upgrade to tendermint 0.30.0 final WIP: Upgrade to tendermint 0.30.0 final Feb 12, 2019
alexanderbez
alexanderbez approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Think we should add a change log entry.

cwgoes
cwgoes approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, update PENDING.md please

@jackzampolin
Copy link
Member

This is also failing tests.

@alessio alessio changed the title WIP: Upgrade to tendermint 0.30.0 final R4R: Upgrade to tendermint 0.30.0 final Feb 12, 2019
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #3618 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3618   +/-   ##
========================================
  Coverage    61.28%   61.28%           
========================================
  Files          186      186           
  Lines        13998    13998           
========================================
  Hits          8578     8578           
  Misses        4876     4876           
  Partials       544      544

@jackzampolin jackzampolin merged commit bbc0a56 into develop Feb 12, 2019
@jackzampolin jackzampolin deleted the alessio/tendermint-0.30.0 branch February 12, 2019 20:22
@cwgoes
Copy link
Contributor

cwgoes commented Feb 13, 2019 •
edited
Loading

@jackzampolin I think we should try to update the changelog whenever we change Tendermint versions.

(I guess I should have requested changes instead of just commenting)

@jackzampolin
Copy link
Member

@cwgoes Will keep an eye out for that in the future. Thanks for mentioning that.

@alessio
Copy link
Contributor Author

alessio commented Feb 13, 2019

PENDING.md was in fact updated

@cwgoes
Copy link
Contributor

cwgoes commented Feb 13, 2019

PENDING.md was in fact updated

Aha, my Github diff was out of date. Sorry! Thanks @alessio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes cwgoes approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @jackzampolin @cwgoes @alexanderbez