R4R: Add validate-genesis command #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
cmd/gaia/init/validate_genesis.go
Outdated
| RunE: func(cmd *cobra.Command, args []string) (err error) { | ||
| var genesis string | ||
| var genDoc types.GenesisDoc | ||
| var genstate app.GenesisState |
There was a problem hiding this comment.
These vars should be defined right before their first usage (aka genesis on line 31 etc.)
rigelrozanski
approved these changes
Jan 25, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3399 +/- ##
==========================================
- Coverage 59.38% 59.19% -0.2%
==========================================
Files 131 132 +1
Lines 9862 9884 +22
==========================================
- Hits 5857 5851 -6
- Misses 3632 3660 +28
Partials 373 373 |
alessio
reviewed
Jan 26, 2019
| } else { | ||
| genesis = args[0] | ||
| } | ||
|
|
There was a problem hiding this comment.
I'd add a diagnostic info here just to inform the user which location genesis.json is being read from:
fmt.Fprintf(os.Stderr, "validating %s", genesis)
There was a problem hiding this comment.
Great add! Thank you!
alessio
approved these changes
Jan 26, 2019
alessio
suggested changes
Jan 26, 2019
|
Thank you for keeping me honest @alessio will do! |
alessio
suggested changes
Jan 26, 2019
|
@jackzampolin any updates on this? Also, |
|
@alexanderbez I did update it Satuday, need to adjust test to not fail. |
alexanderbez
approved these changes
Jan 28, 2019
alessio
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3398
PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: