Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: limit unbonding delegation / redelegations #3372

Merged
merged 4 commits into from
Jan 24, 2019

Conversation

rigelrozanski
Copy link
Contributor

closes #3270

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #3372 into develop will increase coverage by 0.5%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #3372     +/-   ##
==========================================
+ Coverage    58.86%   59.37%   +0.5%     
==========================================
  Files          131      131             
  Lines         9836     9831      -5     
==========================================
+ Hits          5790     5837     +47     
+ Misses        3671     3621     -50     
+ Partials       375      373      -2

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, just a few typos

x/staking/types/errors.go Outdated Show resolved Hide resolved
x/staking/types/errors.go Outdated Show resolved Hide resolved
x/staking/keeper/delegation_test.go Outdated Show resolved Hide resolved
x/staking/keeper/delegation_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto on a few typos, otherwise LGTM.

x/staking/keeper/delegation.go Outdated Show resolved Hide resolved
x/staking/keeper/delegation.go Outdated Show resolved Hide resolved
@cwgoes cwgoes merged commit dc75eb4 into develop Jan 24, 2019
@cwgoes cwgoes deleted the rigel/limit-redelegations branch January 24, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider limiting redelegation/ubd entries as spam prevention
5 participants