Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Add tendermint version command #3285

Merged
merged 2 commits into from
Jan 14, 2019
Merged

R4R: Add tendermint version command #3285

merged 2 commits into from
Jan 14, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 12, 2019 •
edited
Loading

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio changed the title Add tendermint version command R4R: Add tendermint version command Jan 12, 2019
@codecov
Copy link

codecov bot commented Jan 12, 2019 •
edited
Loading

Codecov Report

Merging #3285 into develop will decrease coverage by 0.08%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop   #3285      +/-   ##
==========================================
- Coverage    55.18%   55.1%   -0.09%     
==========================================
  Files          134     134              
  Lines         9526    9540      +14     
==========================================
  Hits          5257    5257              
- Misses        3938    3952      +14     
  Partials       331     331

cwgoes
cwgoes suggested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea; let's clean up the output a bit - do we also have a P2P version? Pretty sure the RPC endpoints dump several more versions, let's see if we can print those too.

server/tm_cmds.go Outdated Show resolved Hide resolved
server/tm_cmds.go Outdated Show resolved Hide resolved
@cwgoes
Copy link
Contributor

cwgoes commented Jan 14, 2019

Tested ACK 👍

alexanderbez
alexanderbez approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, but I left a bit of feedback.

server/tm_cmds.go

"github.com/cosmos/cosmos-sdk/client"
sdk "github.com/cosmos/cosmos-sdk/types"
)

const (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need a constant for this. Should we also have a JSON output option like most commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support JSON in either gaiacli version nor gaiad version. I'd keep it simple, really.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually - I think JSON output is a good idea. Lots of higher-level tooling might want to parse the version output, and I'd rather they not try to parse the raw text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong objections from me, will do then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add this with the standardization of query outputs. Don't need to worry about this @alessio

jackzampolin
jackzampolin approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of this change. Can change the output here to be JSON in a seperate PR if that works.

@jackzampolin jackzampolin merged commit ac82950 into develop Jan 14, 2019
@jackzampolin jackzampolin deleted the alessio/tendermint-version branch January 14, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @cwgoes @alexanderbez @jackzampolin