R4R: Tombstone Implementation #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnya97
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #3225 +/- ##
==========================================
- Coverage 55.34% 55.24% -0.1%
==========================================
Files 135 134 -1
Lines 9596 9517 -79
==========================================
- Hits 5311 5258 -53
+ Misses 3953 3928 -25
+ Partials 332 331 -1 |
sunnya97
force-pushed
the
sunny/tombstone-impl
branch
from
fb4f1c8
to
2b8c670
Compare
alexanderbez
reviewed
Jan 7, 2019
Co-Authored-By: sunnya97 <sunnya97@gmail.com>
alexanderbez
reviewed
Jan 7, 2019
cwgoes
suggested changes
Jan 7, 2019
alexanderbez
suggested changes
Jan 8, 2019
|
Keeping them permanently in jail (never deleting their |
|
Yeah I believe so @sunnya97. |
This was referenced Jan 9, 2019
| @@ -17,26 +17,11 @@ func (k Keeper) AfterValidatorBonded(ctx sdk.Context, address sdk.ConsAddress, _ | |||
| StartHeight: ctx.BlockHeight(), | |||
| IndexOffset: 0, | |||
| JailedUntil: time.Unix(0, 0), | |||
| Tombstoned: false, | |||
|
|
||
| // Slash validator | ||
| // `power` is the int64 power of the validator as provided to/by | ||
| // Tendermint. This value is validator.Tokens as sent to Tendermint via | ||
| // ABCI, and now received as evidence. | ||
| // The revisedFraction (which is the new fraction to be slashed) is passed | ||
| // in separately to separately slash unbonding and rebonding delegations. | ||
| k.validatorSet.Slash(ctx, consAddr, distributionHeight, power, revisedFraction) | ||
| k.validatorSet.Slash(ctx, consAddr, distributionHeight, power, fraction) |
There was a problem hiding this comment.
should update the above comment based on this code change
There was a problem hiding this comment.
This PR gets an approval from me pending addressing the two comments by @rigelrozanski 👍
cwgoes
approved these changes
Jan 10, 2019
|
ACK pending @rigelrozanski comments. |
Co-Authored-By: sunnya97 <sunnya97@gmail.com>
alexanderbez
approved these changes
Jan 10, 2019
This was referenced Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2363
Fixes #3225
Fixes #3253
Spec in #3103
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: