R4R: change --gas=simulate to --gas=auto when sending txs #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
alessio
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #3170 +/- ##
===========================================
+ Coverage 54.72% 54.74% +0.02%
===========================================
Files 132 132
Lines 9425 9425
===========================================
+ Hits 5158 5160 +2
+ Misses 3949 3947 -2
Partials 318 318 |
There was a problem hiding this comment.
LGTM. Thanks @alessio. Left a few comments, lmk your thoughts.
fedekunze
reviewed
Dec 19, 2018
added 3 commits
December 20, 2018 11:08
--gas=simulate caused confusion and could be mistaken for the --simulate flag. Closes: #3162
--gas=simulate caused confusion and could be mistaken for the --simulate flag. Closes: #3162 GasFlagSimulate -> GasFlagAuto
--gas=simulate caused confusion and could be mistaken for the --simulate flag. Closes: #3162
alessio
force-pushed
the
alessio/3162-gas-auto
branch
from
51041e0
to
913d8a8
Compare
fedekunze
approved these changes
Dec 20, 2018
fedekunze
added
the
T: API Breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--gas=simulate caused confusion and could be
mistaken for the --simulate flag.
Closes: #3162
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: