R4R: Add slashing genesis validation #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alexanderbez
suggested changes
Dec 19, 2018
There was a problem hiding this comment.
@jackzampolin you need to update the simulated random genesis parameters for this I presume (see the x/auth param store PR as an example).
Codecov Report
@@ Coverage Diff @@
## develop #3158 +/- ##
===========================================
- Coverage 55.05% 54.93% -0.13%
===========================================
Files 133 133
Lines 9438 9459 +21
===========================================
Hits 5196 5196
- Misses 3922 3943 +21
Partials 320 320 |
|
@alexanderbez You are right! Only saw these errors when I pushed to CI. Don't think I was running the right sims locally. I've fixed the issue. |
alexanderbez
approved these changes
Dec 19, 2018
There was a problem hiding this comment.
One minor change I think, but otherwise LGTM. Also warrants a review from @cwgoes and/or @rigelrozanski on the actual validation of params (are they stated in spec anywhere?).
cmd/gaia/app/sim_test.go
Outdated
| @@ -167,6 +167,10 @@ func appStateFn(r *rand.Rand, accs []simulation.Account) json.RawMessage { | |||
| return appState | |||
| } | |||
|
|
|||
| func between(r *rand.Rand, min, max int) int { | |||
There was a problem hiding this comment.
I'd call this randIntRange.
cwgoes
approved these changes
Dec 19, 2018
cmd/gaia/app/sim_test.go
Outdated
| @@ -167,6 +167,10 @@ func appStateFn(r *rand.Rand, accs []simulation.Account) json.RawMessage { | |||
| return appState | |||
| } | |||
|
|
|||
| func between(r *rand.Rand, min, max int) int { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: