R4R: Move all store keys into constants #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
|
See comment @jackzampolin -- I'm not sure we should be doing this. |
|
@alexanderbez The strings don't provide objcap IIRC, it's because we use memory addresses in the store implementation. |
Codecov Report
@@ Coverage Diff @@
## develop #3119 +/- ##
===========================================
- Coverage 55.05% 54.35% -0.71%
===========================================
Files 133 137 +4
Lines 9430 10234 +804
===========================================
+ Hits 5192 5563 +371
- Misses 3921 4332 +411
- Partials 317 339 +22 |
|
Ahhh right! They are pointers! @jackzampolin can you please rebase? |
alexanderbez
suggested changes
Dec 14, 2018
|
Updated @alexanderbez |
alexanderbez
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PENDING.mdwith issue #Files changedin the github PR explorerThis PR cleans up storekeys, query routes and message routes that were previously defined as string (e.g. "gov" and "acc") and used in many places in the SDK by placing them in their module.
cc @alexanderbez @cwgoes