R4R: x/slashing Query Params

[alexanderbez]

• Implement and mount slashing query (only query params right now)
• Fix JSON tags for params (snakecase -- this "technically" makes it a breaking change)
• Add CLI command to query slashing params
• Add API route to query slashing params

TODO: Docs???

closes: #2399

---

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[jackzampolin]

Indent?

[alexanderbez]

Que?

[jackzampolin]

Does this respect the viper.GetString(client.FlagIndent)?

[alexanderbez]

No. The querier returns JSON marshalled indented bytes, so there is no "option" to pick here.

[alexanderbez]

I'd have deserialized and then re-serialize to support this.

[alexanderbez]

@fedekunze @faboweb @jackzampolin what documentation do I need to update (swagger, CLI, etc...)?

There is one new endpoint and one new command.

[codecov]

Codecov Report

Merging #3117 into develop will increase coverage by 0.03%.
The diff coverage is 76.47%.

@@             Coverage Diff             @@
##           develop    #3117      +/-   ##
===========================================
+ Coverage    54.32%   54.35%   +0.03%     
===========================================
  Files          136      137       +1     
  Lines        10215    10232      +17     
===========================================
+ Hits          5549     5562      +13     
- Misses        4328     4331       +3     
- Partials       338      339       +1

[jackzampolin]

@alexanderbez Yup, the swagger.yaml file needs to get updated (indicated where the new route should go). The CLI docs will also need an update. We need to add a slashing section there and also add the gaiacli tx slashing unjail and gaiacli query slashing signing-info commands

[fedekunze]

LGTM. Just missing tests (LCD, cli) and docs update. Then it should be good to go

[alessio]

Looks good to me

[alexanderbez]

@fedekunze @jackzampolin updated docs + added integration tests

[jackzampolin]

Nice! Thanks for adding the tests! This looks good!