tests and fixes for kvstore iteration #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebuchman
force-pushed
the
sdk2-kvstore-tests
branch
from
188f295
to
b6cfd9a
Compare
ebuchman
changed the title
jaekwon
reviewed
Dec 19, 2017
store/cachemergeiterator.go
Outdated
| @@ -189,8 +194,21 @@ func (iter *cacheMergeIterator) skipUntilExistsOrInvalid() { | |||
| return | |||
| } | |||
|
|
|||
| // If cache not valid but parent is, return | |||
There was a problem hiding this comment.
Should move above the above if clause.
jaekwon
reviewed
Dec 19, 2017
store/cachemergeiterator.go
Outdated
| // Parent and Cache items exist. | ||
| keyP, keyC := iter.parent.Key(), iter.cache.Key() | ||
| var keyP, keyC []byte | ||
| if iter.parent.Valid() { |
There was a problem hiding this comment.
both parent and cache are valid now so these if conditions are unnecessary.
ebuchman
force-pushed
the
sdk2-kvstore-tests
branch
from
d99f10d
to
a7b8d6d
Compare
jaekwon
force-pushed
the
sdk2-kvstore-tests
branch
from
d45b2e4
to
c0598cd
Compare
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 19, 2021
rootulp
referenced
this pull request
in rootulp/cosmos-sdk
Apr 20, 2023
* Bump cosmos sdk to v0.46.11 * chore: use comet pkg instead of tendermint --------- Co-authored-by: evan-forbes <evan.samuel.forbes@gmail.com>
gibson042
pushed a commit
to gibson042/cosmos-sdk
that referenced
this pull request
Apr 12, 2024
Increases the snapshot per item size limit when restoring from state-sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs a fix for TestCacheKVMergeIterator
EDIT: added comprehensive tests!