Fixed failing compile #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Already fixed in master |
This was referenced Oct 24, 2017
Closed
liamsi
pushed a commit
to liamsi/cosmos-sdk
that referenced
this pull request
Jun 26, 2018
Use go-data for nice json un/marshaling
4 tasks
Raumo0
pushed a commit
to mapofzones/cosmos-sdk
that referenced
this pull request
Jun 20, 2021
* add minimum commission rate * fixed DefaultMinCommissionRate comment * Update x/staking/keeper/params.go * Update x/staking/keeper/validator.go * Update x/staking/keeper/validator_test.go * Update x/staking/keeper/validator_test.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/staking/keeper/validator_test.go * fix lint * make proto-all * fix lint * add powerreduction to params * check protobuf breakage against osmo-v0.42.x instead of master Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Raumo0
pushed a commit
to mapofzones/cosmos-sdk
that referenced
this pull request
Sep 14, 2021
* add minimum commission rate * fixed DefaultMinCommissionRate comment * Update x/staking/keeper/params.go * Update x/staking/keeper/validator.go * Update x/staking/keeper/validator_test.go * Update x/staking/keeper/validator_test.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/staking/keeper/validator_test.go * fix lint * make proto-all * fix lint * add powerreduction to params * check protobuf breakage against osmo-v0.42.x instead of master Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
joeabbey
referenced
this pull request
in joeabbey/cosmos-sdk
Jan 21, 2022
* add minimum commission rate * fixed DefaultMinCommissionRate comment * Update x/staking/keeper/params.go * Update x/staking/keeper/validator.go * Update x/staking/keeper/validator_test.go * Update x/staking/keeper/validator_test.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/staking/keeper/validator_test.go * fix lint * make proto-all * fix lint * add powerreduction to params * check protobuf breakage against osmo-v0.42.x instead of master Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Thunnini
referenced
this pull request
in Thunnini/cosmos-sdk
Feb 28, 2022
* add minimum commission rate * fixed DefaultMinCommissionRate comment * Update x/staking/keeper/params.go * Update x/staking/keeper/validator.go * Update x/staking/keeper/validator_test.go * Update x/staking/keeper/validator_test.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/staking/keeper/validator_test.go * fix lint * make proto-all * fix lint * add powerreduction to params * check protobuf breakage against osmo-v0.42.x instead of master Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
RiccardoM
pushed a commit
that referenced
this pull request
Apr 13, 2022
* add minimum commission rate * fixed DefaultMinCommissionRate comment * Update x/staking/keeper/params.go * Update x/staking/keeper/validator.go * Update x/staking/keeper/validator_test.go * Update x/staking/keeper/validator_test.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/staking/keeper/validator_test.go * fix lint * make proto-all * fix lint * add powerreduction to params * check protobuf breakage against osmo-v0.42.x instead of master Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
4 tasks
raynaudoe
pushed a commit
that referenced
this pull request
Sep 22, 2022
fix missing coma should work print block height answer why index null should fix getHeight forgot fmt fix get account at current height check rosetta request misc misc misc misc misc misc misc misc infinite loop
mantrachain-support
added a commit
to mantrachain-support/cosmos-sdk
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses both issues #1 and #2
However, I wonder why the tests don't use the golang testing framework (I have to use
go run ./tests/tmsp/main.goto check the code)? I would happily port if if that is desired. (Probably a separate pull request).