Clip withdrawal tokens #2895
Merged
Clip withdrawal tokens #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaekwon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
|
|
||
| // Clip withdrawal tokens by pool, due to possible rounding errors. | ||
| // https://github.com/cosmos/cosmos-sdk/issues/2888#issuecomment-441387987 | ||
| for i, decCoin := range withdrawalTokens { |
There was a problem hiding this comment.
Can we actually just add a small sentence as to what and why we're doing here?
Codecov Report
@@ Coverage Diff @@
## rigel/blockly-mint #2895 +/- ##
======================================================
- Coverage 56.89% 56.85% -0.04%
======================================================
Files 120 120
Lines 8321 8318 -3
======================================================
- Hits 4734 4729 -5
- Misses 3268 3270 +2
Partials 319 319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.