Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: GenTx command refactoring - take #2 #2881

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Nov 22, 2018

Don't call gaiacli tx sign. Use utils.SignStdTx() instead.

This is to avoid command redirection and reduce the use of viper's global variables.

Closes: #2875

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio changed the title GenTx command refactoring - take #2 R4R: GenTx command refactoring - take #2 Nov 22, 2018
@cwgoes
Copy link
Contributor

cwgoes commented Nov 22, 2018

Sadly the integration_tests fail 😿

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #2881 into develop will decrease coverage by 0.14%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop   #2881      +/-   ##
==========================================
- Coverage    56.84%   56.7%   -0.15%     
==========================================
  Files          120     120              
  Lines         8298    8315      +17     
==========================================
- Hits          4717    4715       -2     
- Misses        3263    3282      +19     
  Partials       318     318

@alexanderbez alexanderbez self-requested a review November 23, 2018 02:58
@alessio
Copy link
Contributor Author

alessio commented Nov 23, 2018

@cwgoes fixed, please review

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. I left a few minor cosmetic suggestions. Also, I'm not 100% sure we do commission param validations (e.g. my given rate can be > the default max rate).

@alessio
Copy link
Contributor Author

alessio commented Nov 23, 2018

@bez comments accepted, thanks

This is to avoid command redirection and reduce the use
of viper's global variables.

Closes: #2875
@alessio alessio force-pushed the alessio/2875-gentx-refactoring-take-2 branch from 36fe200 to 72c9589 Compare November 23, 2018 18:25
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and changes looks clean and concise 👌

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit 4c36b0f into develop Nov 26, 2018
@cwgoes cwgoes deleted the alessio/2875-gentx-refactoring-take-2 branch November 26, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants