-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: GenTx command refactoring - take #2 #2881
Conversation
Sadly the |
Codecov Report
@@ Coverage Diff @@
## develop #2881 +/- ##
==========================================
- Coverage 56.84% 56.7% -0.15%
==========================================
Files 120 120
Lines 8298 8315 +17
==========================================
- Hits 4717 4715 -2
- Misses 3263 3282 +19
Partials 318 318 |
@cwgoes fixed, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM. I left a few minor cosmetic suggestions. Also, I'm not 100% sure we do commission param validations (e.g. my given rate can be > the default max rate).
@bez comments accepted, thanks |
This is to avoid command redirection and reduce the use of viper's global variables. Closes: #2875
36fe200
to
72c9589
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested and changes looks clean and concise 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK
Don't call gaiacli tx sign. Use utils.SignStdTx() instead.
This is to avoid command redirection and reduce the use of viper's global variables.
Closes: #2875
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: