Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Cmds for query deposits #2570

Merged
merged 4 commits into from
Oct 23, 2018
Merged

R4R: Cmds for query deposits #2570

merged 4 commits into from
Oct 23, 2018

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Oct 23, 2018 •
edited
Loading

Closes #2567

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added the wip label Oct 23, 2018
@fedekunze fedekunze changed the title Cmds for query deposits WIP: Cmds for query deposits Oct 23, 2018
@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #2570 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2570   +/-   ##
========================================
  Coverage    60.32%   60.32%           
========================================
  Files          150      150           
  Lines         8613     8613           
========================================
  Hits          5196     5196           
  Misses        3069     3069           
  Partials       348      348

@fedekunze fedekunze changed the title WIP: Cmds for query deposits R4r: Cmds for query deposits Oct 23, 2018
@fedekunze fedekunze changed the title R4r: Cmds for query deposits R4R: Cmds for query deposits Oct 23, 2018
cwgoes
cwgoes approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks @fedekunze

@cwgoes cwgoes merged commit 701a00c into develop Oct 23, 2018
@cwgoes cwgoes deleted the fedekunze/2567-deposits-cmds branch October 23, 2018 18:53
@snyk-bot snyk-bot mentioned this pull request Jan 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@alessio alessio Awaiting requested review from alessio

Assignees
No one assigned
Labels
C:CLI C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedekunze @cwgoes