Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bounds checking and missing return #2468

Merged
merged 1 commit into from
Oct 12, 2018
Merged

fix bounds checking and missing return #2468

merged 1 commit into from
Oct 12, 2018

Conversation

WALL-E
Copy link
Contributor

@WALL-E WALL-E commented Oct 10, 2018

fixed #2466

@WALL-E WALL-E force-pushed the baseapp-fix branch 2 times, most recently from 339f759 to 70e9b74 Compare October 10, 2018 09:41
fedekunze
fedekunze approved these changes Oct 11, 2018
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks ! linter tests should now be fixed on develop so please merge in the latest changes

@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@b921ed2). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             develop   #2468   +/-   ##
=========================================
  Coverage           ?   61.9%           
=========================================
  Files              ?     149           
  Lines              ?    9530           
  Branches           ?       0           
=========================================
  Hits               ?    5900           
  Misses             ?    3213           
  Partials           ?     417

@rigelrozanski rigelrozanski merged commit c653053 into cosmos:develop Oct 12, 2018
@WALL-E WALL-E deleted the baseapp-fix branch October 12, 2018 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@fedekunze fedekunze fedekunze approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: invalid memory address or nil pointer dereference
3 participants
@WALL-E @rigelrozanski @fedekunze